«

[Acero]

EL Quia is correct in their response. Validating the user input is always a requirement.

To expand upon the answer, when the user of your program enters a character into the iostream object(cin) of type int, the int is filled with garbage data and the failbit of the iostream object is set to true. Until the iostream object failbit is cleared and the data in the cin stream is dicarded, your cin is unusable and will not get user input again, hence your infinite loop.

Here is an example of something similar to what you might want to try:

unsigned short int taketarget (unsigned short int records)
     {  
        int target=0;
        
       while (target<1 || target>records)
         { 
			cout << "\nEnter target record number:\n";
			cin >> target;
			if (cin.fail())
			{
				cout << "Invalid Input." << endl;
				cin.clear();
				cin.ignore();
				cout << "Enter a number between 1 and " << records << ".\n";
			}
         }
        return target;
     }

I hope this helps you

[The Fifth Horseman]

Thanks, Acero. This solved the problem perfectly.

[Acero]

I'm quite happy to have been of help. May I ask what kind of project this code was for? School work? Working on a game?

Originally Posted by The Fifth Horseman

Thanks, Acero. This solved the problem perfectly.

[The Fifth Horseman]

A tool to convert sprites from Space Hulk's non-standard format to PCX.